-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal error: entered unreachable code #63164
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hm, this bug probably originates with interesting codegen in Rocket, but is likely a bug in rustc in the end. I would keep it here, though letting Rocket know about it might not be a bad idea. |
I'm going to label this as P-high for now since it affects Rocket. cc @petrochenkov re. macros & privacy. |
Without looking too deeply I would wager that we're getting a rust/src/librustc_privacy/lib.rs Lines 761 to 768 in 676d282
|
Would be great to have a reproducer that did not depend on Rocket and codegen, if it is possible. |
Trying to get a simple reproducible example and am unable to :( It got a little time-consuming and I really need to get work done so have worked around it for now. I could possibly publish everything in a repo, but it would still be rocket + codegen and not a very simple example! |
Latest nightly (2019-08-11) still panics, but with different error message:
|
Also as a sidenote: Rocket master does not ICE anymore. The ICE "was fixed" by rwf2/Rocket@2f458b5 so it may be a problem with decl_macro ? |
@hellow554 I would still wan't |
rust/src/librustc/hir/map/mod.rs Lines 517 to 530 in 60960a2
For future reference, when panicking or using |
I think you got me wrong. I haven't said, that this should be closed because upstream code has changed, but I said, that upstream does not ICE anymore, so I looked into it, what caused it to not ICE anymore.
I try to go that ;) Confirmed, that it is related to decl maros @rustbot modify labels: +A-macros-2.0 |
This comment has been minimized.
This comment has been minimized.
#![feature(decl_macro)]
pub fn moo() {
pub macro ABC() {{}}
}
fn main() {} Backtraces60960a2
dddb7fc
@rustbot modify labels: -E-needs-mcve |
What is the appropriate visibility scope for
In my mind the expected semantics of this could would be to scope I can implement either semantic. @petrochenkov? Edit: I'm talking out of my ass, the scoping rules of |
Seems to be something to do with Rocket. Having a
get
on the internal function is causing the compiler to blow up.Version:
Stack trace:
The text was updated successfully, but these errors were encountered: