Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Miri is in "test pass" state but not available in latest nightly #79129

Closed
ghost opened this issue Nov 17, 2020 · 5 comments · Fixed by #79198
Closed

[Question] Miri is in "test pass" state but not available in latest nightly #79129

ghost opened this issue Nov 17, 2020 · 5 comments · Fixed by #79198
Labels
A-miri Area: The miri tool C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@ghost
Copy link

ghost commented Nov 17, 2020

Miri is in "test pass" state in https://rust-lang-nursery.github.io/rust-toolstate/ since #78990 and #78937 has been closed. Also I didn't found any new issue from @rust-highfive about Miri in rust-lang/rust, so I assume Miri should build from the master branch of it.
However, Miri is not available in the latest nightly (nightly-2020-11-17, f5230fb) from rustup. f5230fb already contains #78990. Actually Miri is missing since nightly-2020-11-10, and is still missing even #78990 has been merged.

I can't find any additional information about Miri in the latest nightly. What's going on with it?

Edit: I mentioned the wrong PR. It should be #78990 instead of #78890.

@RalfJung
Copy link
Member

Oh, I had not even noticed this, thanks! This looks like a rustc issue, so I'll move the issue there.

@RalfJung RalfJung transferred this issue from rust-lang/miri Nov 17, 2020
@RalfJung
Copy link
Member

Cc @rust-lang/infra any idea why Miri is missing from rustup?

@RalfJung
Copy link
Member

The log at https://github.com/rust-lang-ci/rust/runs/1410170664 looks good in terms of tests, but one thing is strange:

{"nomicon":"test-pass","edition-guide":"test-pass","cargo-miri":"test-fail","book":"test-pass","embedded-book":"test-pass","rust-by-example":"test-pass","miri":"test-pass","reference":"test-pass","rustbook":"test-fail","rls":"test-pass","rustfmt":"test-pass"}[master beb7213] (linux CI update)

Notice the "test-fail" for "cargo-miri". However, I don't think anything actually cares about that test state, so I am not sure if this is actually a problem.

I guess something is going wrong when doing the nightly release (Miri has special logic there to avoid shipping when tests fail), but I do not know how to access the logs for that.

@pietroalbini
Copy link
Member

Thanks for the report! This is a bug in our release process: rust-lang/promote-release#30

I guess something is going wrong when doing the nightly release (Miri has special logic there to avoid shipping when tests fail), but I do not know how to access the logs for that.

Release process logs are not available publicly unfortunately :(

@jonas-schievink jonas-schievink added A-miri Area: The miri tool C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 17, 2020
@ghost
Copy link
Author

ghost commented Nov 19, 2020

rust-lang/promote-release#30 has been closed, but Miri is still not available due to #79176. Maybe Miri will be available tomorrow and this can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants