Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build prefix is part of the compiled compiler #82392

Closed
bjorn3 opened this issue Feb 22, 2021 · 0 comments · Fixed by #86025
Closed

The build prefix is part of the compiled compiler #82392

bjorn3 opened this issue Feb 22, 2021 · 0 comments · Fixed by #86025
Labels
A-reproducibility Area: Reproducible / deterministic builds T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Feb 22, 2021

This build prefix is incorrect when using rustup as rustup can install it everywhere. In addition it hurts reproducibility of builds.

let install_prefix = option_env!("CFG_PREFIX").expect("CFG_PREFIX");

Once this is no longer hard coded, the following line should be removed to prevent accidentally depending on it:

.env("CFG_PREFIX", builder.config.prefix.clone().unwrap_or_default());

I noticed this as I forgot to set the prefix and when I set it, it started rebuilding from rustc_codegen_ssa onward.

@bjorn3 bjorn3 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-reproducibility Area: Reproducible / deterministic builds labels Feb 22, 2021
@bors bors closed this as completed in fa38fad Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reproducibility Area: Reproducible / deterministic builds T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant