Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of clean::Function::header once #85833 is merged #89673

Closed
jyn514 opened this issue Oct 8, 2021 · 3 comments · Fixed by #95096
Closed

Get rid of clean::Function::header once #85833 is merged #89673

jyn514 opened this issue Oct 8, 2021 · 3 comments · Fixed by #95096
Assignees
@yuvaldolev
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 8, 2021 •
edited by rustbot
Loading

Originally posted by @jyn514 in #85833 (comment)
@jyn514 jyn514 changed the title Get rid of clean::Function::header once https://github.com/rust-lang/rust/pull/85833 is merged Get rid of clean::Function::header once #85833 is merged Oct 8, 2021
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 8, 2021
@jyn514 jyn514 mentioned this issue Oct 8, 2021
Merged
@yuvaldolev
Copy link
Contributor

@rustbot claim

@jyn514 jyn514 removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Oct 30, 2021
@jyn514
Copy link
Member Author

jyn514 commented Oct 30, 2021

Hi @yuvaldolev, #85833 was merged so you can start working on this :) feel free to ask for help on Zulip.

@yuvaldolev
Copy link
Contributor

Thanks @jyn514!
I'll start working on it

@yuvaldolev yuvaldolev mentioned this issue Nov 25, 2021
Closed
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 19, 2022
Merged
@bors bors closed this as completed in 11909e3 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuvaldolev yuvaldolev

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove header field from clean::Function GuillaumeGomez/rust
2 participants
@jyn514 @yuvaldolev