Convert disallowed macros to an early pass lint

[jdonszelmann]

r? @xFrednet

I forgot one yesterday, but this one also needs to be early pass. I use AttrStorage in a similar way as FormatArgs does. It's not actually very wasteful, there aren't that many attributes, and every attribute used to store its own span, which outside clippy will soon not be necessary anymore.

There's one more that needs refactoring, which @GuillaumeGomez is doing

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[GuillaumeGomez]

I think fmt check will be unhappy but otherwise code looks good to me. Thanks!

[jdonszelmann]

actually I don't think so, I ran tidy on it haha

[jdonszelmann]

yup, but I'll force push over it fixing your comments

[GuillaumeGomez]

Dark magic. 😆

[flip1995]

This only modifies Clippy. Please open this PR towards the Clippy repo.

To do this easily you can do

git diff HEAD~1 --patch -- src/tools/clippy | sed "s|src/tools/clippy/||" > clippy.patch

and then in the Clippy repo clone

git apply /path/to/clippy.patch

[GuillaumeGomez]

Oh good catch. Didn't even notice it was the wrong repository...

[flip1995]

Also the other PR should have been done to the Clippy repo.

To give an explanation for that policy: The Clippy repo runs more tests on Clippy than in the Rust repo. It also uses slightly different formatting rules. Those need to be fixed during syncing the Clippy and the Rust repo. The more changes were done between syncs to Clippy in the Rust repo, the more conflicts there are and the longer the sync takes. So only changes that must be done in the Rust repo, should be done in the Rust repo.

The most important check that is done in Clippy for changes like this: Clippy does a mini-crater run on every PR to see the effect of changes. I have the feeling that a change like this (or rather the ones in the previous PR) can have unexpected effects. Those we (meaning I) would need to catch and potentially fix during the next sync.

[jdonszelmann]

Oh alright. I'll refile it. I did this cause it makes immediately rebasing onto it easy as the root cause of the change is for changes in rust. Otherwise I'd have to wait for 2 weeks for the sync. But it makes sense like that :)

[jdonszelmann]

closed in favor of rust-lang/rust-clippy#13657

[flip1995]

Thank you. I will do the sync tomorrow, as it is already delayed by 1 week because of other changes that blocked it, that needed to be fixed.

So you only have to wait until tomorrow evening :)