Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood more or_patterns in the compiler #71231

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 17, 2020

Another step toward the stabilization of or_patterns...

cc #54883 @Centril
r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2020

📌 Commit e6482c87f380124207f16a60103f74646c52c541 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2020
@Dylan-DPC-zz
Copy link

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2020
@bors
Copy link
Contributor

bors commented Apr 17, 2020

☔ The latest upstream changes (presumably #71049) made this pull request unmergeable. Please resolve the merge conflicts.

@cuviper
Copy link
Member Author

cuviper commented Apr 17, 2020

@Dylan-DPC was that failed as in broke some functionality? Or simply failed to merge -- since this touches a lot of code, conflicts are somewhat likely.

(And now @bors reports a merge conflict anyway, so I'll fix that.)

@Mark-Simulacrum
Copy link
Member

@bors rollup=never

It looks like it just didn't merge (which is expected), this touches a lot of code. Marking as not rolling up.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2020

📌 Commit e6482c87f380124207f16a60103f74646c52c541 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2020
@Dylan-DPC-zz
Copy link

No sorry, by failed I meant due to conflicts not due to the CI

@Dylan-DPC-zz
Copy link

@bors p=1

@Mark-Simulacrum
Copy link
Member

(Well, actually, that approval is useless as this has conflicts, but that's fine. @cuviper feel free to approve as needed).

@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Apr 17, 2020

@Mark-Simulacrum there's a conflict in src/librustc_mir/interpret/intern.rs. Do you still want to r+? :P

nevermind :D

@cuviper cuviper force-pushed the rustc_or_patterns branch from e6482c8 to 1d25129 Compare April 17, 2020 17:22
@cuviper
Copy link
Member Author

cuviper commented Apr 17, 2020

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 17, 2020

📌 Commit 1d251291903788e0c005320e45370a81725a743a has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 18, 2020

⌛ Testing commit 1d251291903788e0c005320e45370a81725a743a with merge b07f26ee00acf5842ccdc54997fab4450a610bd9...

@bors
Copy link
Contributor

bors commented Apr 18, 2020

💔 Test failed - checks-azure

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2020
@bors
Copy link
Contributor

bors commented Apr 19, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2020
@cuviper
Copy link
Member Author

cuviper commented Apr 19, 2020

Timeout installing msys...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2020
@bors
Copy link
Contributor

bors commented Apr 19, 2020

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout rustc_or_patterns (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self rustc_or_patterns --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging src/librustc_typeck/astconv.rs
Auto-merging src/librustc_trait_selection/traits/wf.rs
CONFLICT (content): Merge conflict in src/librustc_trait_selection/traits/wf.rs
Auto-merging src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Auto-merging src/librustc_session/config.rs
Auto-merging src/librustc_passes/check_const.rs
Auto-merging src/librustc_parse/parser/diagnostics.rs
Auto-merging src/librustc_mir/util/pretty.rs
Auto-merging src/librustc_mir/borrow_check/diagnostics/region_name.rs
Auto-merging src/librustc_codegen_llvm/attributes.rs
Auto-merging src/librustc_ast/lib.rs
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2020
@bors
Copy link
Contributor

bors commented Apr 19, 2020

☔ The latest upstream changes (presumably #69793) made this pull request unmergeable. Please resolve the merge conflicts.

@cuviper cuviper force-pushed the rustc_or_patterns branch from 1d25129 to 7b005c5 Compare April 19, 2020 14:34
@cuviper
Copy link
Member Author

cuviper commented Apr 19, 2020

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 19, 2020

📌 Commit 7b005c5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2020
@bors
Copy link
Contributor

bors commented Apr 19, 2020

⌛ Testing commit 7b005c5 with merge ad48d52...

@bors
Copy link
Contributor

bors commented Apr 19, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing ad48d52 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants