Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

might_permit_raw_init: also check arrays (take two) #87041

Closed
wants to merge 4 commits into from
Closed

might_permit_raw_init: also check arrays (take two) #87041

wants to merge 4 commits into from
+117 −3

Conversation

Aaron1011
Copy link
Member

This is a revival of PR #79296 for a fresh Crater run

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 10, 2021

⌛ Trying commit 4f9c4aaa674d3708cdce00fd7cd9684325405553 with merge ad8c22b50457babb1409b03fda810be4d1c3b206...

@bors
Copy link
Contributor

bors commented Jul 10, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 10, 2021

⌛ Trying commit 4f9c4aaa674d3708cdce00fd7cd9684325405553 with merge ecabaf78506b7a4668d42dc20268c086b93f0fad...

@bors
Copy link
Contributor

bors commented Jul 10, 2021

☀️ Try build successful - checks-actions
Build commit: ecabaf78506b7a4668d42dc20268c086b93f0fad (ecabaf78506b7a4668d42dc20268c086b93f0fad)

@Aaron1011
Copy link
Member Author

@craterbot test

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Aaron1011
Copy link
Member Author

@craterbot build-and-test

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Aaron1011
Copy link
Member Author

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-87041 created and queued.
🤖 Automatically detected try build ecabaf78506b7a4668d42dc20268c086b93f0fad
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2021
@Aaron1011 Aaron1011 mentioned this pull request Jul 11, 2021
Closed
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87041 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87041 is completed!
📊 470 regressed and 59 fixed (172237 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 21, 2021
@RalfJung
Copy link
Member

RalfJung commented Jul 21, 2021 •
edited
Loading

Looks like a big one here is hyper:

https://github.com/hyperium/hyper/blob/52214f391c0a18dc66d1ccff9c0c004c5da85002/src/proto/h1/role.rs#L872

Cc hyperium/hyper#2532

@RalfJung RalfJung mentioned this pull request Jul 21, 2021
Closed
@JohnCSimon JohnCSimon removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2021
@craterbot
Copy link
Collaborator

🗑️ Experiment pr-87041-1 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 15, 2021
@Aaron1011
Copy link
Member Author

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-87041-1 created and queued.
🤖 Automatically detected try build ddc023471205c186b40f4bf8ffb598008dbf4885
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87041-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot retry-report

@craterbot
Copy link
Collaborator

🛠️ Generation of the report for pr-87041-1 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87041-1 is completed!
📊 380 regressed and 73 fixed (200076 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 20, 2021
@Aaron1011 Aaron1011 mentioned this pull request Jan 22, 2022
Closed
3 tasks
@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2022
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2022
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2022
@RalfJung
Copy link
Member

So going just over the crates whose name starts with a, b, c, the failures are almost all (>80%) caused by hyper (versions before hyperium/hyper#2545) and ancient crossbeam. I added that info to #66151. It's probably not worth keeping the PR open; I am not sure if old hyper and crossbeam will ever go sufficiently out of use that we can break them entirely.

@RalfJung RalfJung mentioned this pull request Mar 27, 2022
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Mar 27, 2022

We could backport patches to these old crates... I'm sure we can get the maintainers to do that if we do the impl work

@RalfJung
Copy link
Member

RalfJung commented Mar 27, 2022 •
edited
Loading

Patches that don't raise the MSRV might be tricky though.

@RalfJung
Copy link
Member

RalfJung commented Mar 27, 2022 •
edited
Loading

Also, tons of lockfiles will reference the old versions. So we'd also have to convince crater to do cargo update before doing its thing.

(I am pretty sure it currently doesn't do that, considering how many different versions of hyper 0.14 I saw in the crater logs.)

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 8, 2022 •
edited
Loading

Also, tons of lockfiles will reference the old versions. So we'd also have to convince crater to do cargo update before doing its thing.

(I am pretty sure it currently doesn't do that, considering how many different versions of hyper 0.14 I saw in the crater logs.)

That's correct, this is currently not done, somewhat intentionally -- when possible, we try to avoid breaking builds even if cargo update is enough to fix things. Ideally we'd get both statuses, but that's a bunch of extra Crater time.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#95374 - RalfJung:assert_uninit_valid, r=Mar…
bdcefe9 
…k-Simulacrum

assert_uninit_valid: ensure we detect at least arrays of uninhabited types

We can't easily extend this check to *all* arrays (Cc rust-lang#87041), but it turns out the existing check already catches arrays of uninhabited types. So let's make sure it stays that way by adding them to the test.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#95374 - RalfJung:assert_uninit_valid, r=Mar…
9010879 
…k-Simulacrum

assert_uninit_valid: ensure we detect at least arrays of uninhabited types

We can't easily extend this check to *all* arrays (Cc rust-lang#87041), but it turns out the existing check already catches arrays of uninhabited types. So let's make sure it stays that way by adding them to the test.
@RalfJung RalfJung closed this Apr 15, 2022
@RalfJung RalfJung mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.