Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add rustc lint, warning when iterating over hashmaps" #90380

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Revert "Add rustc lint, warning when iterating over hashmaps" #90380

merged 1 commit into from
Oct 29, 2021

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Oct 28, 2021 •
edited
Loading

Fixes perf regressions introduced in #90235 by temporarily reverting the relevant PR.

@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2021
@bors
Copy link
Contributor

bors commented Oct 28, 2021

⌛ Trying commit 3215eeb with merge d578b629e8453aab208b4844130124ba17747757...

@bors
Copy link
Contributor

bors commented Oct 28, 2021

☀️ Try build successful - checks-actions
Build commit: d578b629e8453aab208b4844130124ba17747757 (d578b629e8453aab208b4844130124ba17747757)

@rust-timer
Copy link
Collaborator

Queued d578b629e8453aab208b4844130124ba17747757 with parent f2707fe, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d578b629e8453aab208b4844130124ba17747757): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -8.9% on incr-full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 28, 2021
@Mark-Simulacrum
Copy link
Member Author

r? rust-lang/compiler for r+ of this revert

@lcnr
Copy link
Contributor

lcnr commented Oct 28, 2021

@bors r+

probably the best until i fix this

@bors
Copy link
Contributor

bors commented Oct 28, 2021

📌 Commit 3215eeb has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2021
@lcnr lcnr assigned lcnr and unassigned davidtwco Oct 28, 2021
@bors
Copy link
Contributor

bors commented Oct 29, 2021

⌛ Testing commit 3215eeb with merge 88a5a98...

@bors
Copy link
Contributor

bors commented Oct 29, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 88a5a98 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2021
@bors bors merged commit 88a5a98 into rust-lang:master Oct 29, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 29, 2021
@bors bors mentioned this pull request Oct 29, 2021
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (88a5a98): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -8.9% on incr-full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@lcnr
Copy link
Contributor

lcnr commented Jan 5, 2022

cc #89558

@lcnr lcnr mentioned this pull request Jan 5, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#92584 - lcnr:query-stable-lint, r=estebank
508fb37 
add rustc lint, warning when iterating over hashmaps 2

first introduced in rust-lang#89558 and reverted in rust-lang#90380 due to its perf impact

r? `@estebank`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#92584 - lcnr:query-stable-lint, r=estebank
741b62a 
add rustc lint, warning when iterating over hashmaps 2

first introduced in rust-lang#89558 and reverted in rust-lang#90380 due to its perf impact

r? ``@estebank``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @rust-timer @bors @lcnr @davidtwco @rustbot