Make TAIT behave exactly like RPIT #96727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
no_expect
branch
2 times, most recently
from
f93c109 to
9a6821a
Compare
lcnr
reviewed
Jun 3, 2022
|
☔ The latest upstream changes (presumably #95565) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Addressed review comment and rebased (causing some diagnostics changes in positions of diagnostics) |
|
☔ The latest upstream changes (presumably #97892) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
☔ The latest upstream changes (presumably #98656) made this pull request unmergeable. Please resolve the merge conflicts. |
… async fn desugaring, make that explicit
|
@bors r+ |
|
📌 Commit c33b127 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 29, 2022
Make TAIT behave exactly like RPIT fixes rust-lang#96552 This makes type-alias-impl-trait behave like return-position-impl-trait. Unfortunately it also causes some cases to stop compiling due to "needing type annotations" and makes panicking cause fallback for the hidden type to `()`. All of these are addressable, but we should probably address them for RPIT and TAIT together r? `@lcnr`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#96727 (Make TAIT behave exactly like RPIT) - rust-lang#98681 (rustdoc-json: Make default value of blanket impl assoc types work) - rust-lang#98682 (add tests for ICE 94432) - rust-lang#98683 (add test for ice 68875) - rust-lang#98685 (Replace `sort_modules_alphabetically` boolean with enum) - rust-lang#98687 (add test for 47814) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96552
This makes type-alias-impl-trait behave like return-position-impl-trait. Unfortunately it also causes some cases to stop compiling due to "needing type annotations" and makes panicking cause fallback for the hidden type to
().All of these are addressable, but we should probably address them for RPIT and TAIT together
r? @lcnr