Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(const_trait_impl): rustfmt earts const keyword #4650

Closed
andre-richter opened this issue Jan 17, 2021 · 3 comments
Closed

feature(const_trait_impl): rustfmt earts const keyword #4650

andre-richter opened this issue Jan 17, 2021 · 3 comments
Labels
bug Panic, non-idempotency, invalid code, etc. duplicate

Comments

@andre-richter
Copy link
Member

Describe the bug

rustfmt eats the const in an impl const

To Reproduce

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=ae26c3383019895433746dc93dfceb5c

Expected behavior

the const should persist if the feature is active.

Meta

  • rustfmt version: nightly
@andre-richter andre-richter added the bug Panic, non-idempotency, invalid code, etc. label Jan 17, 2021
@andre-richter andre-richter mentioned this issue Jan 17, 2021
Closed
@calebcartwright
Copy link
Member

Thanks for the report but closing as a duplicate of #4084 which is still pending backporting

@andre-richter
Copy link
Member Author

I should have used the search function for closed bugs as well. Sorry!

@calebcartwright
Copy link
Member

No worries! We've got some weird branching stuff going on that's resulted in things that have been long fixed in source and associated issues long since closed, but which haven't been released and that makes things tough to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Panic, non-idempotency, invalid code, etc. duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andre-richter @calebcartwright