Make result of GuestAddressSpace::memory() cloneable #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI expected to fail until vorner/arc-swap#25 is pushed to crates.io. |
bonzini
force-pushed
the
clone-guard
branch
3 times, most recently
from
28ee43f to
e433bc6
Compare
This makes it possible to upgrade the short-lived pointer returned by memory() to an owned pointer that can be stored. The bound is already provided by the trivial GuestAddressSpaces (references and Rc/Arc) and also by ArcSwap via vorner/arc-swap#26. Signed-off-by: Paolo Bonzini <[email protected]>
Merged
jiangliu
approved these changes
Mar 19, 2020
andreeaflorescu
approved these changes
Mar 19, 2020
bonzini
added a commit
to andreeaflorescu/vm-memory
that referenced
this pull request
Mar 19, 2020
Signed-off-by: Paolo Bonzini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this in order to update vm-virtio for GuestAddressSpace support. Unfortunately this requires support in the arc-swap crate too.