Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate windows-rs/windows-sys changes for 9x/Me/unicows support #16

Closed
seritools opened this issue Jan 4, 2024 · 2 comments
Closed
Assignees
Labels
9x/Me enhancement New feature or request help wanted Extra attention is needed

Comments

@seritools
Copy link
Member

seritools commented Jan 4, 2024

  • The default "god import" library is imported before unicows.lib, so it prevents unicows from working correctly
  • target checks are too strict and wont link the god import library on rust9x anyways
    • this affects all additional targets like the new win7 one, so I created a fix PR for the official repo
  • Switching to raw-dylib runs into Investigate raw-dylib support/workarounds for unicows #15.
  • link! specifies library names with .dll, making it tricky to change it to #[link(name = "<libraryname>")]
    • one way would be to link everything, without raw-dylib, to kernel32, since kernel32 is always linked. Other dependencies will need to be manually specified in the link args, then.
@seritools seritools added enhancement New feature or request help wanted Extra attention is needed 9x/Me labels Jan 4, 2024
@seritools seritools self-assigned this Jan 4, 2024
@seritools
Copy link
Member Author

I've added two branches to rust9x/windows-rs, one for NT-based Windows only and another one with 9x/Me/unicows support: https://github.com/rust9x/windows-rs/branches

Added info about it in the Limitation wiki entry as well.

@seritools
Copy link
Member Author

All official releases that include microsoft/windows-rs#2774 should also work for NT-based systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9x/Me enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant