Project clean up and maintenance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, sort dependencies because I'm a neat freak.
When running coverage using Python < 3.10, we don't want to see the warnings about being unable to parse code that uses the `match` construct introduce in Python 3.10. In addition, remove `--cov=tests` because coverage is meant to measure only how much of the _main_ code is covered during test execution, not how much _test_ code is covered. Lastely, change `term` to `term-missing` to identify _exactly_ which lines of code are not covered by tests.
Also, replace explicit check for `VIRTUAL_ENV` with `pip`'s `--require-virtualenv` flag in `install` recipe.
Also added py312
In addition: - Add python 3.12 to matrix - Fold dependency caching config into setup-python action - Ignore root user warnings from pip - Allow type checks to run on pre-3.10 code without file duplication
Also, exclude `.venv/` from `flake8` coverage for those who prefer to use that instead of `venv/` for virtualenvs.
Closed
francium
approved these changes
Aug 8, 2024
|
Thank you. Best to break up into smaller and more focused PRs in future though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@francium, this fixes #10.
Aside from updating the versions of the github actions in
ci.yml, I did a bit of closely related cleanup/unification as well, but hopefully there aren't too many changes for your liking in this single PR:lazydocsdependency, thus allowingmake docsto succeedlint-flaketo work across all supported python versions (eliminating need forlint-flake-pre310)Please let me know if I've gone a bit overboard here, but these are all (other than typo fixes and markdown linting) related to improving the build process and test coverage.