Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ok_or and ok_or_else methods. #15

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Add ok_or and ok_or_else methods. #15

merged 6 commits into from
Aug 20, 2024

Conversation

chuckwondo
Copy link
Contributor

Fixes #9

francium
francium reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@francium francium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will have more comments, just early feedback right now

.github/workflows/ci.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/maybe/maybe.py Outdated Show resolved Hide resolved
src/maybe/maybe.py Show resolved Hide resolved
tests/test_maybe.py Outdated Show resolved Hide resolved
francium
francium reviewed Aug 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@chuckwondo chuckwondo requested a review from francium August 18, 2024 22:32
francium
francium reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@francium francium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, just a few small things.

README.md Outdated Show resolved Hide resolved
src/maybe/maybe.py Outdated Show resolved Hide resolved
tests/test_maybe.py Outdated Show resolved Hide resolved
@chuckwondo chuckwondo requested a review from francium August 19, 2024 12:10
@francium francium merged commit 93926b4 into rustedpy:master Aug 20, 2024
5 checks passed
@francium francium mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francium francium francium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ok_or and ok_or_else methods
2 participants
@chuckwondo @francium