-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize testing/linting configuration #65
Conversation
Great work @wbolster 👍 |
thanks, still polishing a bit, hence the draft status. i'd like to fold in all mypy config, including excludes, into |
030c263
to
6e76299
Compare
urgh 🙄 it turned out that
in however it seems that:
computers were a mistake hehe 🙈 |
6e76299
to
d7da737
Compare
ok, all good it seems 👍🏼 pls have a look @francium (no rush) 🙏🏼 |
d7da737
to
480eb35
Compare
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
===========================================
- Coverage 100.00% 97.91% -2.09%
===========================================
Files 3 4 +1
Lines 227 239 +12
===========================================
+ Hits 227 234 +7
- Misses 0 5 +5
|
i think i addressed all feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing. Otherwise, great!
This simplifies and modernizes the configuration for various testing and linting tools. Use pyproject.toml as the central location for all configuration as much as possible. Details: - Move pytest config to pyproject.toml (modern location) - Move mypy config to pyproject.toml (modern location) - Move unit test files into already existing tests/ dir; use importable and recognized-by-default-by-pytest names. - Remove seemingly unnecessary coveragerc file; it seemed mostly old and outdated copy/paste of boilerplate. - Move tool config out of CI config files as much as possible (coverage report filenames etc) which is not only cleaner but also better for local development because it will use the same settings. - make yamllint happy about all yaml/yml files
480eb35
to
4521666
Compare
This simplifies and modernizes the configuration for various testing and
linting tools. Use pyproject.toml as the central location for all
configuration as much as possible.
Details:
use importable and recognized-by-default-by-pytest names.
old and outdated copy/paste of boilerplate.
report filenames etc) which is not only cleaner but also better for
local development because it will use the same settings.