Refactor rubies install and remove tasks #219
Conversation
|
@danochoa I will be able to test this on Monday. I will get back to you! |
…le into cleanup-rubies-tasks
| failed_when: False | ||
| register: detect_rubies | ||
| with_items: '{{ rvm1_rubies }}' | ||
| when: rvm1_rubies is defined and rvm1_rubies | length > 0 |
There was a problem hiding this comment.
I think we can generally avoid checking if variables are defined in specific cases where the variable is defined in defaults/main.yml. Just my thoughts. If code owners agree, I will probably open a separate PR to clean this up throughout the other tasks. Othewise, I'm happy to continue always checking if a variable is defined before using it.
| changed_when: False | ||
| register: rvm1_list_installed_rubies | ||
| when: rvm1_delete_ruby is defined and rvm1_delete_ruby != '' | ||
|
|
||
| - name: Delete ruby if relevant |
There was a problem hiding this comment.
With rvm1_delete_ruby as a string (single ruby), I think we can leave this alone for now. If this becomes a list we can use the difference from rvm_list_strings similar to the install task.
|
@thbar this is ready for another review when you get a chance. Thanks. |
|
@danochoa I will only be able to check this out in ~2 weeks (but will do that if nobody has done it before). Poke @rvm/ansible if someone else is more available right now! |
| command: '{{ rvm1_rvm }} {{ item }} do true' | ||
| - name: Detect rubies | ||
| command: '{{ rvm1_rvm }} list strings' | ||
| register: rvm_list_strings |
There was a problem hiding this comment.
I believe this point fails with --check enabled. I don't think it is a huge deal at this point though, because other parts will probably also break or output incorrect stuff (e.g. no changes where changes should be reported), so I think we can leave with that for now.
|
@rvm/ansible can anyone have a second look? On my end I believe this can be merged, and we will improve things with the next PRs. |
I think this should help clean up a bit and resolves #218.