Migrate CI to GitHub Actions #235

sfgeorge · 2022-03-24T22:00:08Z

Switch to GitHub Actions for testing. Fixes #233

Included

Test existing suite of OSs
~~Added Rocky Linux 8, Debian 11 and Ubuntu 21.10~~
Fixed OS issues related to 'aging'.

Not Included

For sake of speed, Docker and Ansible are no longer version-pinned.
Since these tools are provided in GitHub Runners by default, the provided versions are used instead.
The build status badge on ansible-galaxy is not currently being updated.
Please see this issue as to why: Support any CI-server for notifications. ansible/galaxy#46 – ansible-galaxy only accepts build status updates in the format that Travis-CI JSON produces. An Action would need to be written to transform GitHub Action build status results into the Travis-based JSON schema, and POST to ansible-galaxy.

Test Status in this PR

You may notice that this PR is still hung on Travis-CI and has not triggered a GitHub Actions Workflow as of yet. This is expected:

When a first-time contributor submits a pull request to a public repository, a maintainer with write access may need to approve running workflows on the pull request. For more information, see "Approving workflow runs from public forks."

To see this PR's GitHub Actions' output, please review Switch from Travis-CI to GitHub Actions for tests sfgeorge/rvm1-ansible#1

Test Status Once Merged: Yes, it Should be Failing

Update key server URLs and decommission of sks-keyservers.net #232 is merged, so this PR should pass when merged!
To see this GitHub Actions Workflow in action (and passing) prior to merge, please see my fork (uses the same branch as this PR): Switch from Travis-CI to GitHub Actions for tests sfgeorge/rvm1-ansible#1

Thanks to https://techglimpse.com/failed-metadata-repo-appstream-centos-8/

…und' TASK [rvm1-ansible : Configure rvm] [...] "stderr": "/opt/rvm/scripts/rvm: line 25: ps: command not found\nRVM not loaded, aborting."

TASK [rvm1-ansible : Import GPG keys from keyservers] gpg: directory '/root/.gnupg' created gpg: keybox '/root/.gnupg/pubring.kbx' created gpg: failed to start the dirmngr '/usr/bin/dirmngr': No such file or directory gpg: connecting dirmngr at '/root/.gnupg/S.dirmngr' failed: No such file or directory gpg: keyserver receive failed: No dirmngr

TASK [rvm1-ansible : Install rvm installer] [...] "msg": "Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)>", "url": "https://raw.githubusercontent.com/rvm/rvm/master/binscripts/rvm-installer"}

It's not out yet. Give rvm/rvm project some to deal with the following issue: Ubuntu 22.04 installs OpenSSL 3 instead of 1.1. RVM will need to take steps to continue to compile Ruby against libssl-dev 1.1 instead of 3.

GitHub Runners come with Ansible already

This reverts commit f6bdfa8.

.github/workflows/tests.yml

CHANGELOG.md

README.md

tests/dockerfiles/centos8/Dockerfile

pkuczynski

Some changes and clarifications are needed...

README.md

thbar

Overall I applaud the efforts, many thanks @sfgeorge! Reliable CI is critical for this project, where everyone has low bandwidth.

Just a few remarks, but I would be tempted to go ahead and see if we find troubles.

…Hub Actions

.github/workflows/tests.yml

pkuczynski · 2022-03-26T21:36:51Z

Overall I applaud the efforts, many thanks @sfgeorge! Reliable CI is critical for this project, where everyone has low bandwidth.

I copy @thbar here! Thank you @sfgeorge for your work on this! Merging in :)

sfgeorge · 2022-03-26T22:14:26Z

Thank you!

sfgeorge added 29 commits March 21, 2022 19:46

[CI] GitHub Action tests

90b1817

[DOC] Switch build badge to read from the GitHub Action

4da22da

[CI] Basic test setup

3246f29

[CI] Remove Travis-CI config

89645d5

[CI] Fix CentOS 6 build by using vault.centos.org

152c920

Thanks to https://techglimpse.com/failed-metadata-repo-appstream-centos-8/

[CI] Add testing and support for Debian 11 and Ubuntu 21.10 & 22.04

9f42158

[CI] Fixes for launching Ubuntu 21 & 22

d802707

[CI] Add CentOS Stream 8

077276f

[CI] Fix CentOS 8 build by using vault.centos.org

ae249e0

Thanks to https://techglimpse.com/failed-metadata-repo-appstream-centos-8/

[CI] Explicitly shut down containers

afd13c8

[CI] Start with a 2 minute timeout for CentOS 6

577a09f

[CI] Fix reference to matrix context

599ddd1

[CI] Add Docker Image Caching

8019d2d

[CI] Add Docker Image Caching: Fix

e35a190

[CI] Rename the task that runs the test

c792a66

[CI] Set a 29 minute timeout for CentOS 6 to avoid early shutdown

fcdda1b

[CI] Centos Stream 8: Ensure ps is installed to avoid 'command not fo…

dbcf88a

…und' TASK [rvm1-ansible : Configure rvm] [...] "stderr": "/opt/rvm/scripts/rvm: line 25: ps: command not found\nRVM not loaded, aborting."

[CI] Drop testing for beta Ubuntu 22.04

2c248da

It's not out yet. Give rvm/rvm project some to deal with the following issue: Ubuntu 22.04 installs OpenSSL 3 instead of 1.1. RVM will need to take steps to continue to compile Ruby against libssl-dev 1.1 instead of 3.

[CI] Remove unneeded setup-python GitHub Action

3d37e87

GitHub Runners come with Ansible already

[CI] Test against Centos Stream 9

f6bdfa8

[CI] Restore "Parallelize the test matrix" behavior from rvm#215

23a9d8c

Revert "[CI] Test against Centos Stream 9"

0837d74

This reverts commit f6bdfa8.

[CI] Replace CentOS Stream with Rocky Linux

ef6bf23

[CI] Ubuntu 21.10: Restrict time to 29 min

a05ff4f

[DOC] Update CHANGELOG PR reference

eec3578

[CI] Rocky Linux 8: Add required findutils package

3e1454c

DOC] Update CHANGELOG PR reference

07c36e3

sfgeorge requested a review from a team as a code owner March 24, 2022 22:00

Merge branch 'master' into github-actions

87fbc6a

pkuczynski assigned sfgeorge Mar 25, 2022

pkuczynski added the enhancement label Mar 25, 2022

pkuczynski reviewed Mar 25, 2022

View reviewed changes

pkuczynski requested changes Mar 25, 2022

View reviewed changes

pkuczynski requested review from gildegoma and lpaulmp March 25, 2022 20:47

Merge branch 'master' into github-actions

b9a7f68

thbar reviewed Mar 26, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

thbar reviewed Mar 26, 2022

View reviewed changes

This was referenced Mar 26, 2022

Improve Bundler setup to support RVM aliases #52

Open

Travis CI: Verify that "Ansible --check mode" passes #220

Open

sfgeorge added 6 commits March 26, 2022 14:46

[CI] [DOC] Add a comment around scheduled workflow

5352666

[CI] Run CI on any branch push

afc62bb

[DOC] Align YAML comments with Steps

c20b465

[DOC] Update CHANGELOG entry to include principal change: Migrate Git…

bbc946f

…Hub Actions

[CI] Use CentOS from Docker Hub

51d3f5f

[CI] Make this PR purely about CI switch (no added OSs)

6b37dba

sfgeorge requested review from thbar and pkuczynski March 26, 2022 19:41

Update CHANGELOG.md

5313d0d

pkuczynski approved these changes Mar 26, 2022

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

pkuczynski changed the title ~~GitHub actions~~ Migrate CI to GitHub Actions Mar 26, 2022

pkuczynski merged commit 4b5650d into rvm:master Mar 26, 2022

thbar mentioned this pull request Apr 10, 2022

Releases not being pulled by Ansible Galaxy #236

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate CI to GitHub Actions #235

Migrate CI to GitHub Actions #235

sfgeorge commented Mar 24, 2022 •

edited

Loading

pkuczynski left a comment

thbar left a comment

pkuczynski commented Mar 26, 2022

sfgeorge commented Mar 26, 2022

Migrate CI to GitHub Actions #235

Migrate CI to GitHub Actions #235

Conversation

sfgeorge commented Mar 24, 2022 • edited Loading

Included

Not Included

Test Status in this PR

Test Status Once Merged: Yes, it Should be Failing

pkuczynski left a comment

Choose a reason for hiding this comment

thbar left a comment

Choose a reason for hiding this comment

pkuczynski commented Mar 26, 2022

sfgeorge commented Mar 26, 2022

sfgeorge commented Mar 24, 2022 •

edited

Loading