Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line finder improvements #43

Open
rwesson opened this issue Apr 28, 2016 · 0 comments
Open

Line finder improvements #43

rwesson opened this issue Apr 28, 2016 · 0 comments
Milestone

Comments

@rwesson
Copy link
Owner

rwesson commented Apr 28, 2016

The line finder is very crude and could be improved:

  • a multiple pass approach identifying strong lines first and searching for progressively weaker lines could avoid things like a bright CEL being misidentified as a nearby faint ORL.
  • fitting a polynomial function to the shift instead of assuming it's linear might cope better with the uncertainties of wavelength calibrations
@rwesson rwesson added this to the v2.6 milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant