Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ttc files don't work #175

Closed
lilyball opened this issue Jul 7, 2017 · 7 comments
Closed

.ttc files don't work #175

lilyball opened this issue Jul 7, 2017 · 7 comments

Comments

@lilyball
Copy link
Collaborator

lilyball commented Jul 7, 2017

Subject of the issue

The font patcher doesn't handle .ttc files correctly. It produces a weirdly-named file that seems to contain the data for the first font in the .ttc file, though Font Book.app says it doesn't pass validation.

I tried this using /System/Library/Fonts/Menlo.ttc.

FWIW here's an old unmerged PR that adds support for .ttc files to the Powerline font patcher.

Your Setup

  • macOS 10.12.5
@ryanoasis
Copy link
Owner

@kballard Okay thanks 😄 I wasn't aware of this.

It would be nice to support this eventually provided we get some help 😊, however I would say this is not a high priority

@ruro
Copy link

ruro commented Aug 26, 2017

Same problem on Manjaro Linux with the default Noto Sans font.
My workaround is to use fontforge to convert .ttc to .ttf before patching the font:
fontforge -lang=pe -c "Open(\$1);Generate(\$1:r+'.ttf')" SomeFont-Regular.ttc

@ryanoasis
Copy link
Owner

I have some renewed interest in supporting this 😄

@LuRsT
Copy link
Collaborator

LuRsT commented Apr 2, 2018

We could add that bit that @ruro mentioned to the docs or make this a future feature, since you have renewed interest in supporting this, is it going to be in the roadmap @ryanoasis ?

@ryanoasis
Copy link
Owner

since you have renewed interest in supporting this

Oh I did say that didn't I? 😆

I think we can try to target v2.1.0 (i.e. next release) unless I am missing it looked somewhat straight forward to implement.

@benfrain
Copy link

Could this be the reason I can't patch Iosevka Slab following the readme? #735

@Finii Finii mentioned this issue Jan 5, 2022
2 tasks
@Finii Finii mentioned this issue Feb 9, 2022
2 tasks
@Finii Finii closed this as completed Jan 29, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@lilyball @LuRsT @benfrain @ruro @ryanoasis @Finii and others