Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaskaydiaCove: letters with diacritics (e.g. ö, é, ę, etc.) look wrong #451

Closed
yogan opened this issue Mar 13, 2020 · 9 comments
Closed

Comments

@yogan
Copy link

yogan commented Mar 13, 2020

🎯 Subject of the issue

I am currently trying out the patched Cascadia Code font, CaskaydiaCove. It looks really nice, and the extended glyphs are working just fine. However, letters with diacritics, like ö, é, ę, etc., are somehow rendered wrong. They are thinner, and generally have a different shape; it almost looks like they are coming from a different font. The screenshot below shows this pretty well.

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • CaskaydiaCove Nerd Font Mono (also tried CaskaydiaCove NF, no difference)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Windows 10, v1909 (18363.719)

★ Optional

image

@craftbyte
Copy link

I can confirm this issue, also by checking the original font, the characters are there.

@wonrax
Copy link

wonrax commented Dec 15, 2021

It does not support Vietnamese characters too. The original font does.

@Finii
Copy link
Collaborator

Finii commented Dec 15, 2021

It is a font naming problem and would be fixed with #717.

Look here:
image

The columns are: Font-Filename, Fullname, Family, Subfamily

It gets the SubFamily wrong, and then the wrong font is choosen because it is grouped (incorrectly) with Cascadia Code that you for shure have installed in parallel.

Solutiion:

  • Remove Cascadia Code (is a pain)
  • Wait till we correct the naming scheme
  • (Hate to say this again, but there is still Delugia, which was just automagically updated to Cascadia v2111.01)

@Finii
Copy link
Collaborator

Finii commented Dec 15, 2021

Here in look into the patched font file in the repo (patched_fonts/):
image

Same thickness. The problem is the font grouping in Windows, which is done (correctly) by Family and not Fullname (and we get that wrong).

@wonrax
Copy link

wonrax commented Dec 15, 2021

It gets the SubFamily wrong, and then the wrong font is choosen because it is grouped (incorrectly) with Cascadia Code that you for shure have installed in parallel.

I actually use CascadiaCode Nerd Font instead of CaskaydiaCove, does this still apply?

And I still don't quite get it, even if it chooses the wrong font, then the characters shouldn't be missing since all the Cascadia fonts I've installed below support Vietnamese characters.

image

@wonrax
Copy link

wonrax commented Dec 15, 2021

I just checked, apparently, my CascadiaCode Nerd Font that I downloaded a while ago is not the same as this font (CaskaydiaCove). I saw the name and wrongfully thought it came from this repository. I just installed the CaskaydiaCove from the patched-fonts folder and it supports all the Vietnamese characters. Sorry for the trouble.

@Finii
Copy link
Collaborator

Finii commented Dec 15, 2021

Thanks for the feedback. :)

@Finii Finii closed this as completed Dec 15, 2021
@Finii
Copy link
Collaborator

Finii commented Dec 15, 2021

image

😭

The naming is broken in so many places.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants