From 21d59f10c1aeb70298fe4f438d1c1b2af937a71d Mon Sep 17 00:00:00 2001 From: Rys Sommefeldt Date: Sat, 5 Jan 2019 16:08:30 +0000 Subject: [PATCH] Hoist the body read out of the error branch and don't defer close --- src/mbdns.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mbdns.go b/src/mbdns.go index d90d1aa..ee82afa 100644 --- a/src/mbdns.go +++ b/src/mbdns.go @@ -68,17 +68,17 @@ func process() { response, err := http.PostForm(mbURL, url.Values{"domain": {records[i].Domain}, "password": {records[i].Token}, "command": {command}}) + body, _ := ioutil.ReadAll(response.Body) + response.Body.Close() + if err != nil { log.Println(fmt.Sprintf(mbResponseError, records[i].Host, records[i].Domain, records[i].Record, records[i].TTL, err.Error())) continue } - defer response.Body.Close() - if response.StatusCode != 200 { log.Println(fmt.Sprintf(mbResponseError, records[i].Host, records[i].Domain, records[i].Record, records[i].TTL, response.Status)) - body, _ := ioutil.ReadAll(response.Body) log.Printf("%s", body) continue