Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift-tab in the notebook should go back 4 spaces instead of going to the previous input cell #6368

Closed
williamstein opened this issue Jun 20, 2009 · 5 comments

Comments

@williamstein
Copy link
Contributor

Right now, in the notebook, usually shift-tab goes back to the previous input cell. Since tab goes forward 4 spaces (or if text is highlighted, indents it), and shift-tab unindents highlighted text, it would by far make the most sense if shift-tab when no text is highlighted just goes back 4 spaces.

CC: @TimDumol

Component: notebook

Author: Alex Leone

Reviewer: Mitesh Patel

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/6368

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Jan 20, 2010

Author: Alex Leone

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Jan 20, 2010

comment:1

Attachment: trac_6368-shift_tab_unindents.patch.gz

Should I add any Selenium tests?

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

Reviewer: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

comment:2

Nice work!

  • This works as expected in Cr4, FF3.5.7, & S4 on Windows XP and Cr4 & FF3.5.6 on Linux.
  • In O10 on XP and Linux, shift-tab for non-empty selections was already broken and is still broken.
  • In IE8 on XP, auto-indentation and tab/shift-tab were already broken and they still are.

We can make new tickets for the latter two. It seems that a given browser behaves more consistently across platforms than different browsers on a given platform, but it would be great to get feedback on various browsers on Mac OS. Usually, we test what we can, e.g., the locally available combinations, ourselves and receive more varied data from the field (alphas, rcs, and releases).

On the Se tests: Please feel free to try! In my experience, Se does not handle at least some keys (e.g., TAB) consistently across browsers. So far, we've tested mostly in Firefox. It's relatively easy to set up Se Grid to test other browsers. But I've found getting the Se tests to pass in more than one browser is a tedious affair. Moreover, the results are very sensitive to seemingly innocuous changes in HTML, etc. Nevertheless, we should refine and extend our suite to cover more notebook functions.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Merged: sagenb-0.7

@qed777 qed777 mannequin removed the s: positive review label Jan 25, 2010
@qed777 qed777 mannequin closed this as completed Jan 25, 2010
@qed777 qed777 mannequin mentioned this issue Feb 10, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants