Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make recognition of runpath/develpath in editmodule more robust #7961

Closed
nbruin opened this issue Jan 17, 2010 · 4 comments
Closed

Make recognition of runpath/develpath in editmodule more robust #7961

nbruin opened this issue Jan 17, 2010 · 4 comments
Assignees
@nbruin
Labels
p: major / 3 t: bug
Milestone
sage-4.3.1

Comments

@nbruin
Copy link
Contributor

nbruin commented Jan 17, 2010

Currently, the code that recognizes a source file is part of the sage library and hence is run from a different location than where the edit copy lives, is broken due to the python2.5 -> python2.6 upgrade. Attached fixes this problem and makes matching more robust so that it won't break the next time. To illustrate the problem, currently we have

sage: sage.misc.edit_module.file_and_line(edit)
('/usr/local/sage/4.3/local/lib/python2.6/site-packages/sage/misc/edit_module.py', 194)

which obviously is NOT the file to edit. It should be .../sage/devel/... instead. Attached patch fixes this.

Component: misc

Author: Nils Bruin

Reviewer: Tim Dumol

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7961
@nbruin nbruin added this to the sage-4.3.2 milestone Jan 17, 2010
@nbruin nbruin self-assigned this Jan 17, 2010
@nbruin
Copy link
Contributor Author

nbruin commented Jan 17, 2010

Attachment: edit_module.patch.gz

making misc.edit_module pathname mangling more robust

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

comment:2

LGTM.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

Reviewer: Tim Dumol

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 19, 2010

Merged: sage-4.3.1.rc1

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
@mwhansen mwhansen modified the milestones: sage-4.3.2, sage-4.3.1 Jan 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbruin nbruin

Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.1
Development

No branches or pull requests
2 participants
@mwhansen @nbruin