From 679a841baeafcad6ce3beb84208792164d196cc4 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Wed, 11 Sep 2024 21:59:20 +0530 Subject: [PATCH] Revert "[IconButton] Fix hover background color behavior (#43271)" This reverts commit d9d0a37d6e11b83b3fefa716915cb1161a7a91db. --- .../mui-material/src/IconButton/IconButton.js | 3 -- .../src/IconButton/IconButton.test.js | 32 +------------------ 2 files changed, 1 insertion(+), 34 deletions(-) diff --git a/packages/mui-material/src/IconButton/IconButton.js b/packages/mui-material/src/IconButton/IconButton.js index 05747642096d82..38237214ef8798 100644 --- a/packages/mui-material/src/IconButton/IconButton.js +++ b/packages/mui-material/src/IconButton/IconButton.js @@ -164,7 +164,6 @@ const IconButton = React.forwardRef(function IconButton(inProps, ref) { color = 'default', disabled = false, disableFocusRipple = false, - disableRipple = false, size = 'medium', ...other } = props; @@ -175,7 +174,6 @@ const IconButton = React.forwardRef(function IconButton(inProps, ref) { color, disabled, disableFocusRipple, - disableRipple, size, }; @@ -187,7 +185,6 @@ const IconButton = React.forwardRef(function IconButton(inProps, ref) { centerRipple focusRipple={!disableFocusRipple} disabled={disabled} - disableRipple={disableRipple} ref={ref} {...other} ownerState={ownerState} diff --git a/packages/mui-material/src/IconButton/IconButton.test.js b/packages/mui-material/src/IconButton/IconButton.test.js index 76011f1d2dbf29..25ca0ca6b2b9d3 100644 --- a/packages/mui-material/src/IconButton/IconButton.test.js +++ b/packages/mui-material/src/IconButton/IconButton.test.js @@ -1,7 +1,7 @@ import * as React from 'react'; import { expect } from 'chai'; import PropTypes from 'prop-types'; -import { createRenderer, reactMajor, fireEvent } from '@mui/internal-test-utils'; +import { createRenderer, reactMajor } from '@mui/internal-test-utils'; import capitalize from '@mui/utils/capitalize'; import { ThemeProvider, createTheme } from '@mui/material/styles'; import IconButton, { iconButtonClasses as classes } from '@mui/material/IconButton'; @@ -141,34 +141,4 @@ describe('', () => { )).not.to.throw(); }); - - it('should apply the hover background by default', function test() { - if (!/jsdom/.test(window.navigator.userAgent)) { - this.skip(); - } - - const { container, getByTestId } = render(); - - fireEvent.mouseMove(container.firstChild, { - clientX: 19, - }); - expect(getByTestId('icon-button')).toHaveComputedStyle({ - backgroundColor: 'rgba(0, 0, 0, 0.04)', - }); - }); - - it('should not apply the hover background if disableRipple is true', function test() { - if (!/jsdom/.test(window.navigator.userAgent)) { - this.skip(); - } - - const { container, getByTestId } = render( - , - ); - - fireEvent.mouseMove(container.firstChild, { - clientX: 19, - }); - expect(getByTestId('icon-button')).toHaveComputedStyle({ backgroundColor: 'rgba(0, 0, 0, 0)' }); - }); });