Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems using the "Dialog" mode #25

Closed
LarYoungruu opened this issue Jul 15, 2020 · 7 comments
Closed

Problems using the "Dialog" mode #25

LarYoungruu opened this issue Jul 15, 2020 · 7 comments

Comments

@LarYoungruu
Copy link

LarYoungruu commented Jul 15, 2020 •
edited
Loading

Problems using the "Dialog" mode
The white space for the first item with top , the last item with the bottom is quite large
Using maxHeight does solve the smaller dialog display but doesn't solve the white space top and bottom

https://i.ibb.co/sFRPqJD/Screen-Shot-2020-07-15-at-12-53-55-PM.png
@salim-lachdhaf
Copy link
Owner

Could you paste an examlpe of your code ?

@LarYoungruu
Copy link
Author

LarYoungruu commented Aug 17, 2020 •
edited
Loading

@salim-lachdhaf
Hey bro.
I tried creating with a brand new project.
Example:
DropdownSearch(
mode: Mode.DIALOG,
showSelectedItem: true,
items: ["Brazil", "Italia (Disabled)", "Tunisia", 'Canada'],
label: "Menu mode",
hint: "country in menu mode",
popupItemDisabled: (String s) => s.startsWith('I'),
onChanged: print,
selectedItem: "Brazil",
maxHeight: 300,
),

https://i.ibb.co/yq9Vwwj/Screen-Shot-2020-08-17-at-16-29-35.png

@LarYoungruu
Copy link
Author

@salim-lachdhaf
Have you come across this issue?

@salim-lachdhaf
Copy link
Owner

No, could you test on another device, or on android device

@silvinhodev
Copy link

I have same problem with 2 devices

@salim-lachdhaf
Copy link
Owner

Are you sure that your data did not contains any empty string ?

@salim-lachdhaf
Copy link
Owner

this issue is fixed in this next version v0.4.6

salim-lachdhaf added a commit that referenced this issue Oct 30, 2020
@salim-lachdhaf
v 0.4.6
c4436f6 
Invoke the dropdown programmatically
change dropdownSearch selected value programmatically
fix issue #25
fix issue #36
fix issue #51
fix issue #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@salim-lachdhaf @LarYoungruu @silvinhodev