[CALCITE-4188] Add hints from review

sap-contributions · Dec 9, 2024 · 626269a · 626269a
1 parent c4d955f
commit 626269a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcCorrelationDataContext.java b/core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcCorrelationDataContext.java
@@ -36,6 +36,7 @@ public JdbcCorrelationDataContext(DataContext delegate, Object[] parameters) {
     this.delegate = delegate;
     this.parameters = parameters;
   }
+
   @Override public @Nullable SchemaPlus getRootSchema() {
     return delegate.getRootSchema();
   }

diff --git a/core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcImplementor.java b/core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcImplementor.java
@@ -65,6 +65,8 @@ public Result implement(RelNode node) {
       return context;
     }
     List<RelDataTypeField>  fieldList = variable.getType().getFieldList();
+    // We need to provide a context which also includes the correlation variables
+    // as dynamic parameters.
     return new Context(dialect, fieldList.size()) {
       @Override public SqlNode field(int ordinal) {
         RelDataTypeField field = fieldList.get(ordinal);

diff --git a/core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java b/core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java
@@ -1384,6 +1384,10 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
     });
   }
 
+  /**
+   * Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-4188">[CALCITE-4188]
+   * Support EnumerableBatchNestedLoopJoin for JDBC</a>. */
   @Test void testBatchNestedLoopJoinPlan() {
     final String sql = "SELECT *\n"
         + "FROM \"s\".\"emps\" A\n"