From 7055b70f35a6af60440be4de720dbf3a401f3095 Mon Sep 17 00:00:00 2001 From: "Kent C. Dodds" Date: Wed, 16 Mar 2016 06:32:21 -0600 Subject: [PATCH] fix(compat): Fix issues with node@^0.10 --- .eslintignore | 4 ++++ .travis.yml | 4 ---- bin.js | 5 +++-- index.js | 4 +++- package.json | 3 ++- test.js | 2 +- 6 files changed, 13 insertions(+), 9 deletions(-) create mode 100644 .eslintignore diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 0000000..7a2355e --- /dev/null +++ b/.eslintignore @@ -0,0 +1,4 @@ +node_modules/ +coverage/ +.nyc_output/ + diff --git a/.travis.yml b/.travis.yml index 35a16f6..04a4c75 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,10 +7,6 @@ notifications: email: false node_js: - '4' - - iojs-v3 - - iojs-v2 - - iojs-v1 - - '0.12' - '0.10' before_install: - npm i -g npm@^3.0.0 diff --git a/bin.js b/bin.js index aa8b4ae..2640074 100755 --- a/bin.js +++ b/bin.js @@ -5,7 +5,8 @@ // Prints rules recognized by ESLint that don't appear in the given config // preset. It helps with upgrading the preset when new ESLint gets released. var path = require('path') -var findNewRules = require('.') +var isAbsolute = require('path-is-absolute') +var findNewRules = require('./index') var currentRules = Object.keys(getConfig().rules) var newRules = findNewRules(currentRules) @@ -19,7 +20,7 @@ function getConfig() { var specifiedFile = process.argv[2] if (specifiedFile) { // this is being called like: eslint-find-new-rules eslint-config-mgol - if (path.isAbsolute(specifiedFile)) { + if (isAbsolute(specifiedFile)) { return require(specifiedFile) } else { return require(path.join(process.cwd(), specifiedFile)) diff --git a/index.js b/index.js index 9d1833f..606b212 100644 --- a/index.js +++ b/index.js @@ -6,7 +6,9 @@ module.exports = findNewRules function findNewRules(currentRules) { var allRules = fs .readdirSync('./node_modules/eslint/lib/rules') - .map(filename => filename.replace(/\.js$/, '')) + .map(function removeJsFromFilename(filename) { + return filename.replace(/\.js$/, '') + }) return difference(allRules, currentRules) } diff --git a/package.json b/package.json index f0d9f2b..f7f1db7 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,8 @@ ], "license": "MIT", "dependencies": { - "lodash.difference": "4.1.1" + "lodash.difference": "4.1.1", + "path-is-absolute": "1.0.0" }, "devDependencies": { "ava": "0.13.0", diff --git a/test.js b/test.js index 5123a69..04a65bc 100644 --- a/test.js +++ b/test.js @@ -1,6 +1,6 @@ import mock from 'mock-fs' import test from 'ava' -import findNewRules from '.' +import findNewRules from './index' try { require('./bin') // requiring now for coverage until this is tested