Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RecvRaw #896

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

WqyJh
Copy link
Contributor

@WqyJh WqyJh commented Nov 12, 2024

To address the need for reading raw stream lines or customizing stream responses, we have introduced a RecvRaw method to the streamReader. This enhancement allows for more flexible and direct interaction with stream data.

Fixes #887, #889.

@sashabaranov
Copy link
Owner

@WqyJh thank you for the PR! Please the latest changes from master here, so the CI will pass

@WqyJh WqyJh force-pushed the feat-stream-raw-lines branch from 75a0d8f to eb92809 Compare November 20, 2024 03:18
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.86%. Comparing base (774fc9d) to head (eb92809).
Report is 75 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   98.46%   98.86%   +0.40%     
==========================================
  Files          24       26       +2     
  Lines        1364     1764     +400     
==========================================
+ Hits         1343     1744     +401     
+ Misses         15       14       -1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WqyJh
Copy link
Contributor Author

WqyJh commented Nov 20, 2024

Fixed @sashabaranov

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@sashabaranov sashabaranov merged commit c203ca0 into sashabaranov:master Nov 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing Customization of Stream Return Type in CreateChatCompletionStream
2 participants