-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass watcher doesn't re-compile on changes to meta.load-css() loaded modules? #1808
Comments
This is more or less expected. We could potentially restructure the watcher logic to look at which files are actually loaded during a given compilation rather than relying on static analysis, but this would be a fairly substantial engineering effort. For now, I'll list this as a low-priority enhancement. |
As CSS is adding more of these architectural tools (layers, scope, etc) - these issues are becoming more and more important. As we're designing these features at the CSSWG, the main question we always get is 'how can I load stylesheets into one of these structures'. In every case we end up adding additional I don't think that's a low priority to address somehow. It may be that we want to address it in some other way - but 'nested imports' are becoming more and more central to basic CSS functionality. We need to give that some attention. |
(sorry, I meant to open this in the sass repo - not sure why I ended up in dart-sass) |
Miriam and I talked about this, and we're going to handle it by special-casing |
(I'm using v1.55.0)
In order to use CSS
@layer
efficiently on an existing code-base, I switched from e.g.:to:
That's by far the simplest upgrade path, rather than wrapping each module individually with a layer or mixin.
But since making that change, the watcher no longer compiles any changes to modules other than
screen.scss
itself. Changes to any of the loaded modules are ignored by the watcher. I don't see anything about that in the docs, or the specs, or any other issues mentioning it - but I was able to reproduce the problem consistently.Is that the expected behavior? Are others able to reproduce this?
The text was updated successfully, but these errors were encountered: