Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should libsass have a compact function? #585

Closed
xzyfer opened this issue Oct 28, 2014 · 8 comments · Fixed by #835
Closed

Should libsass have a compact function? #585

xzyfer opened this issue Oct 28, 2014 · 8 comments · Fixed by #835
Assignees
Milestone

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Oct 28, 2014

I've noticed libsass defines a compact($values...) function. Ruby sass doesn't appear to now or ever had this function. Since we're aiming for 3.4 parity this should probably go.

@akhleung
Copy link

Yeah, I think we needed it for Bourbon support at one point ... not really necessary now that variadic functions are natively supported.

@mgreter
Copy link
Contributor

mgreter commented Dec 11, 2014

IMO this is closely related to #489

@xzyfer
Copy link
Contributor Author

xzyfer commented Dec 11, 2014

I agree. This feature however would seem to have less adoption, and there a pure sass implementation is trivial. I'm ok with merging #588 to remove this.

@KittyGiraudel
Copy link

compact has never been part of Ruby Sass. It is an old function from Compass thus has nothing to do in LibSass in my opinion.

@davidangel
Copy link

I'm confused by this, isn't 'compact' documented here: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#output_style

Why wouldn't all of these options get included?

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 14, 2015

@davidangel that's the compact output style. This is in regards to a native compact function that Sass currently does not have http://sass-lang.com/documentation/Sass/Script/Functions.html

@davidangel
Copy link

@xzyfer so is there support for the compact output style currently? I've been trying to use it with gulp-sass/nose-sass without much luck...

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 14, 2015

No there is not. We only support nested and compressed. Feel free to open an issue to support that output style.

For the moment it's a low priority. We recommend using PostCSS is you want to manipulate the output styles.

@mgreter mgreter assigned mgreter and xzyfer and unassigned mgreter Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants