Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Multiple pen colors in same page. #68

Open
saurabhdaware opened this issue Jul 9, 2020 · 7 comments
Open

Multiple pen colors in same page. #68

saurabhdaware opened this issue Jul 9, 2020 · 7 comments
Labels
css issue can be solved using css javascript issue can be solved using javascript Unclaimed Issue is open for anyone who wants to claim and start working on it

Comments

@saurabhdaware
Copy link
Owner

A lot of people reached out to me on mails and Twitter to have this feature.

We can keep everything the way it is right now, but we can also allow users to select text and then change the value in drop-down to color only the selected part.

@saurabhdaware saurabhdaware added css issue can be solved using css javascript issue can be solved using javascript Unclaimed Issue is open for anyone who wants to claim and start working on it labels Jul 9, 2020
@Himanshunitrr
Copy link
Contributor

To color the font or the background sir.Will like to work on this too.

@saurabhdaware
Copy link
Owner Author

#34 (comment)

@Rishika1416
Copy link

we are a team of developers ,we would like to add this feature .Can we proceed?

@saurabhdaware
Copy link
Owner Author

Yes, sure! Just make sure they are in two different PRs that can be merged separately.

@Rishika1416
Copy link

yeah! I will make sure to make two different PRs . Will update you soon with any progress.

@Rishika1416
Copy link

@saurabhdaware Could you please share the acceptance test criteria so that we can work with better efficiency and understand what do you expect after this issue is resolved.

@saurabhdaware
Copy link
Owner Author

We can keep everything the way it is right now, but we can also allow users to select text and then change the value in drop-down to color only the selected part.

This ^. So normally when I select ink color, it changes the color of the whole text.

After the PR,

  • if we select a particular text and then change the ink color in dropdown, it will only color the selected part and leave the other part as it is.
  • if we don't select any text, then it will change the color of the whole input (the way it works right now)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css issue can be solved using css javascript issue can be solved using javascript Unclaimed Issue is open for anyone who wants to claim and start working on it
Projects
None yet
Development

No branches or pull requests

3 participants