Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to kotlin-logging #1424

Closed
nulls opened this issue Jul 5, 2022 · 4 comments · Fixed by #1529
Closed

Migrate to kotlin-logging #1424

nulls opened this issue Jul 5, 2022 · 4 comments · Fixed by #1529
Assignees
@nulls
Labels
backlog

Comments

@nulls
Copy link
Member

nulls commented Jul 5, 2022

Need to migrate to https://github.com/MicroUtils/kotlin-logging instead of usage SLF4J.
@nulls nulls mentioned this issue Jul 5, 2022
Merged
1 task
@orchestr7
Copy link
Member

Are you sure? Ktlint decided NOT to use Kotlin-logging

@petertrr
Copy link
Member

@akuleshov7 ktlint does use kotlin-logging and we already started to use it in 43e6098

@orchestr7
Copy link
Member

ah, nice! then what is this issue for?

@petertrr
Copy link
Member

There is also an opened #1394 but I'm not sure which parts of these tasks are left. Need to reconsider it for the next minor release probably.

@orchestr7 orchestr7 assigned petertrr and nulls and unassigned petertrr Sep 13, 2022
@nulls nulls mentioned this issue Oct 31, 2022
Merged
1 task
@nulls nulls closed this as completed Nov 15, 2022
@nulls nulls linked a pull request Nov 15, 2022 that will close this issue
Update dependency io.github.microutils:kotlin-logging-jvm to v3 #1529
Merged
1 task
@petertrr petertrr mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency io.github.microutils:kotlin-logging-jvm to v3 saveourtool/diktat
3 participants
@nulls @petertrr @orchestr7