Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive WRONG_OVERLOADING_FUNCTION_ARGUMENTS #1623

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

icemachined
Copy link
Member

What's done:

test case

Closes #1594

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no fix needed? only test?

@icemachined
Copy link
Member Author

no fix needed? only test?

yes, test shows that the bug is not reproduced

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1623 (f500935) into master (416171f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1623   +/-   ##
=========================================
  Coverage     82.47%   82.47%           
  Complexity     2334     2334           
=========================================
  Files           112      112           
  Lines          7862     7862           
  Branches       2045     2045           
=========================================
  Hits           6484     6484           
  Misses          452      452           
  Partials        926      926           
Flag Coverage Δ
unittests 82.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@orchestr7
Copy link
Member

orchestr7 commented Mar 14, 2023

no fix needed? only test?

yes, test shows that the bug is not reproduced

may be there is an interference of different inspections? @icemachined one inspection breaks the code before the next one. Need to check with our online DEMO provided by @sanyavertolet

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 024 tests  +2   2 009 ✔️ +2   23m 32s ⏱️ + 6m 32s
   166 suites ±0        15 💤 ±0 
   166 files   ±0          0 ±0 

Results for commit f500935. ± Comparison against base commit 416171f.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   166 files  +  1     166 suites  +1   29m 14s ⏱️ - 1m 18s
2 024 tests +21  1 985 ✔️ +1  34 💤 +19  5 +1 
2 029 runs  +22  1 990 ✔️ +2  34 💤 +19  5 +1 

For more details on these failures, see this check.

Results for commit f500935. ± Comparison against base commit 416171f.

@icemachined
Copy link
Member Author

no fix needed? only test?

yes, test shows that the bug is not reproduced

may be there is an interference of different inspections? @icemachined one inspection breaks the code before the next one. Need to check with our online DEMO provided by @sanyavertolet

Found that this is because save-cloud has diktat version 1.2.4.1 which was cut 29.07.2022 before overload feature was merged. That's why it is not working in save-cloud now.

@icemachined icemachined merged commit cb102a2 into master Mar 15, 2023
@icemachined icemachined deleted the bugfix/overloadfuncarg branch March 15, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive WRONG_OVERLOADING_FUNCTION_ARGUMENTS
2 participants