Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported multiple reporters in maven #1824

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 27, 2023

What's done:

  • supported reporters to configure reporters in maven
  • supported a default location for all reporters

Now maven plugin supports configuration like:

<reporters>
    <plain/>
    <gitHubActions/>
    <json>
        <output>${project.build.directory}/json-report/report.json</output>
    </json>
</reporters>

It closes #1818

### What's done:
- supported reporters to configure reporters in maven
- supported a default location for all reporters

It closes #1818
@nulls nulls self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (2030a14) 78.64% compared to head (f259d5d) 78.27%.

Files Patch % Lines
...l/diktat/plugin/maven/reporters/DefaultReporter.kt 0.00% 20 Missing ⚠️
...ourtool/diktat/plugin/maven/reporters/Reporters.kt 0.00% 15 Missing ⚠️
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 9 Missing ⚠️
...at/plugin/maven/reporters/GitHubActionsReporter.kt 0.00% 7 Missing ⚠️
.../diktat/plugin/gradle/extension/DefaultReporter.kt 0.00% 5 Missing ⚠️
...otlin/com/saveourtool/diktat/plugin/maven/Utils.kt 0.00% 5 Missing ⚠️
...eourtool/diktat/plugin/maven/reporters/Reporter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1824      +/-   ##
============================================
- Coverage     78.64%   78.27%   -0.38%     
  Complexity     2432     2432              
============================================
  Files           126      131       +5     
  Lines          8562     8603      +41     
  Branches       2171     2173       +2     
============================================
  Hits           6734     6734              
- Misses          862      903      +41     
  Partials        966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   10m 10s ⏱️ + 4m 8s
1 399 tests ±0  1 363 ✔️ ±0  36 💤 ±0  0 ±0 
2 778 runs  ±0  2 742 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit e857f3d. ± Comparison against base commit 2030a14.

Copy link
Contributor

github-actions bot commented Nov 27, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 23s ⏱️ +8s
1 399 tests ±0  1 382 ✔️ ±0  17 💤 ±0  0 ±0 
2 778 runs  ±0  2 761 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit f259d5d. ± Comparison against base commit 2030a14.

♻️ This comment has been updated with latest results.

@nulls nulls marked this pull request as ready for review November 27, 2023 14:04
@nulls nulls merged commit 3c572f1 into master Nov 27, 2023
19 of 20 checks passed
@nulls nulls deleted the feature/multiple-reporters-maven#1818 branch November 27, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple reporters in Maven
2 participants