-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable recompilation when no avro schemas are in project #172
Conversation
I don't see why we need this:
I added a test in #173 to illustrate this. The sbt output after the test step is
We see the record being re-compiled. |
records, outDir, out.log, strType, fieldVis, enbDecimal, useNs, | ||
optionalGetters, createSetters, builder | ||
) | ||
(outDir ** JavaFileFilter).get.toSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we do not want to recompile those every time since this will impact all files including the model.
I think we can integrate that in the caching mechanism so it is compiled only once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, my patience and sbt knowledge was insufficient when writing this.
2ddee02
to
cb6b72d
Compare
033aa42
to
2027c8b
Compare
Currently a project without any avro schemas, but with a
avroSpecificRecords
configuration will not recompile those schemas.If
avroSpecificRecords
contains records, this would always recompile those schemas.