Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scala major versions rather than patch for generated actions #158

Open
mdedetrich opened this issue Jul 3, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@mdedetrich
Copy link
Contributor

When generating the various github action workflows sbt-github-actions uses the full Scala version (i.e. https://github.com/sbt/sbt-github-actions/blob/main/.github/workflows/ci.yml#L26). sbt now supports running a build against a specific Scala major version instead of the full patch version with the .x syntax, i.e. sbt ++2.12.x will load the sbt build with the the Scala 2.12 version defined by scalaVersion sbt setting.

Ultimately this solution would make the generated github action workflows less brittle when Scala patch versions are updated (i.e. no change is necessary). In turn this also makes it easier to add github status checks for workflows that Involve a Scala version since its only sensitive to epic/major instead of the whole version.

@nafg
Copy link

nafg commented Jun 18, 2024

#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants