Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for appending timestamps to RPM snapshots #1008

Closed
keirlawson opened this issue Jul 20, 2017 · 4 comments
Closed

Add option for appending timestamps to RPM snapshots #1008

keirlawson opened this issue Jul 20, 2017 · 4 comments

Comments

@keirlawson
Copy link
Contributor

To differentiate between multiple different snapshot RPMs it would be great to have a (off by default) flag the would automatically append the timestamp to the RPM version, similar to what the Maven RPM plugin does by default: http://www.mojohaus.org/rpm-maven-plugin/version-mojo.html#release

@muuki88
Copy link
Contributor

muuki88 commented Jul 22, 2017

Thanks for your feature request.

IMHO this is something we shouldn't add a setting for. We either implement it by default or we provide a simple recipe on how to implement it yourself as this is straightforward to do. sbt-release has some examples on how to set release versions.

@keirlawson
Copy link
Contributor Author

Ok that sounds reasonable, I guess the argument in favour of doing it by default is it mirrors what the Maven plugin does making it an easier switch, argument against is that its possibly surprising/non-obvious. Certainly as someone coming from Maven having it there by default would help my use case however I don't know how representative my own use case is.

@muuki88
Copy link
Contributor

muuki88 commented Jul 26, 2017

Cool. Thanks for your understanding 😊
Releasing is not strictly a part of native-packager so I'm always very suspicious if it should be included.

@muuki88 muuki88 closed this as completed Jul 26, 2017
@dpennell
Copy link
Contributor

dpennell commented Aug 5, 2017

@keirlawson the rpmRelease setting provides a convenient way to do what you want. See https://docs.fedoraproject.org/ro/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch01s03.html for background. We've been using a timestamp formatted in sorting order (YYYY.MM.DD.HH.MM.SS.UTC) to achieve maven snapshot-like behavior with yum install/upgrade. We are in the process of moving to using sbt-dynver instead of simple timestamps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants