Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINTAINER in Dockerfile #1033

Closed
NeQuissimus opened this issue Sep 25, 2017 · 6 comments
Closed

MAINTAINER in Dockerfile #1033

NeQuissimus opened this issue Sep 25, 2017 · 6 comments
Labels
docker

Comments

@NeQuissimus
Copy link
Contributor

As per moby/moby#25466, the MAINTAINER keyword has been deprecated.
I believe we still use it.

Instead, a LABEL is supposed to be used now.

I may send in a PR soon-ish but wanted to open the issue for tracking, in case I do not get around to it.
@NeQuissimus NeQuissimus mentioned this issue Sep 25, 2017
Merged
@muuki88 muuki88 added the docker label Sep 25, 2017
@muuki88
Copy link
Contributor

muuki88 commented Sep 25, 2017

Thanks for taking care of this 😍
I'm currently on vacation so I won't be able to release anything.

How do we make sure to not break older clients?

@NeQuissimus
Copy link
Contributor Author

LABELs have existed forever and a half (Docker 1.6.0). They are just moving the one-off MAINTAINER onto that mechanism.

@muuki88
Copy link
Contributor

muuki88 commented Sep 26, 2017

Okay perfect 👍 looking forward for your PR 😍

@NeQuissimus
Copy link
Contributor Author

#1034

@muuki88
Copy link
Contributor

muuki88 commented Sep 26, 2017

Thanks 😅
Not used to work on my phone 😁

@NeQuissimus
Copy link
Contributor Author

No worries, enjoy your vacation and leave this alone, it can wait! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NeQuissimus @muuki88