Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default dockerBaseImage value should be set to Java 8. #1146

Closed
wjlow opened this issue Aug 7, 2018 · 3 comments · Fixed by #1147
Closed

Default dockerBaseImage value should be set to Java 8. #1146

wjlow opened this issue Aug 7, 2018 · 3 comments · Fixed by #1147
Labels

Comments

@wjlow
Copy link
Contributor

wjlow commented Aug 7, 2018

Expected behaviour

Not setting dockerBaseImage should default to some version of Java 8, which is the most recent Java version that is supported by Scala.

Actual behaviour

dockerBaseImage is set to openjdk:latest, the latest tag changed from 8 to 10 recently. This can cause problems in Scala apps.

Information

  • What sbt-native-packager are you using: 1.3.6
  • What sbt version: 1.1.1
  • What is your build system (e.g. Ubuntu, MacOS, Windows, Debian ): MacOS
  • What package are you building (e.g. docker, rpm, ...): docker
  • What version has your build tool (find out with e.g. rpm --version): 18.03.0-ce
  • What is your target system (e.g. Ubuntu 16.04, CentOS 7): Not sure
@muuki88
Copy link
Contributor

muuki88 commented Aug 7, 2018

Thanks for your detailed report 👍

Would you mind fixing this? This sounds like a reasonable suggestestion. IIRC there maybe something like openjdk:java8-latest?

@muuki88 muuki88 added the docker label Aug 7, 2018
@wjlow
Copy link
Contributor Author

wjlow commented Aug 7, 2018

Yup, openjdk:8 should give the latest Java 8.

I can try and raise a PR!

@wjlow
Copy link
Contributor Author

wjlow commented Aug 7, 2018

Raised #1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants