Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put Spotify docker-client back in provided scope #1194

Closed
gpgekko opened this issue Jan 24, 2019 · 3 comments · Fixed by #1196
Closed

Put Spotify docker-client back in provided scope #1194

gpgekko opened this issue Jan 24, 2019 · 3 comments · Fixed by #1196
Labels
docker

Comments

@gpgekko
Copy link
Contributor

gpgekko commented Jan 24, 2019

The jdeb dependency was resolved in issue #1097, but the docker packager still needs to be refactored for the docker-client dependency to be moved back into the provided scope.
@muuki88 muuki88 added the docker label Jan 25, 2019
@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2019

Yep 😄 Can you open a PR for this?

@gpgekko gpgekko mentioned this issue Jan 25, 2019
Merged
@gpgekko
Copy link
Contributor Author

gpgekko commented Jan 25, 2019

Was just working on that. My Scala knowledge is limited though.

@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2019

That's no issue 👍 Open Source is to learn 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to move docker-client dependency back to the provided scope
2 participants
@muuki88 @gpgekko