After dist, play do not pick up jars from lib directory

[hadesara]

After Play dist
In the bash/bat script under bin. Currently it has a hardcoded list of jar files that must be loaded in runtime. However if you add any additional jar files in the 'lib' directory it will not be pickup by runtime. Instead, better approach would to loop through the lib directory and all the jar files.

[jsuereth]

We purposely don't do this for a very subtle reason: Jar ordering.

It is entirely possible that the order in which you pass jars is important for correct execution of the program, thanks to shaded ibraries, multi-versioned libraries and all sorts of other madness. If you need additional jars at runtime, I believe you can sneak them into the classpath that the packager looks at by hand.

Also, in the M1 you can provide your own BASH template which does just as you mention. If you'd like to contribute an option to use such a variant BASH template instead, I'd be all for that. However, I think the default behavior should be to have the order of the JARs at production match your dev environment. Configuring another option is then a conscious choice, but one that's probably ok for 80-90% of applications.

[hadesara]

If so, at least this: #124 should be doable right?
Where do I find this BASH template?

[jsuereth]

Here: https://github.com/sbt/sbt-native-packager/blob/master/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template

So I'm closing this as a duplicate of #124