Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker permission strategy warning when Docker version can't be detected #1233

Open
TimMoore opened this issue May 29, 2019 · 1 comment
Open
Labels

Comments

@TimMoore
Copy link

The Docker plugin attempts to detect the current running Docker version, and validate that the selected permission strategy is compatible with the detected version.

If None is detected, it doesn't warn the user that they have an incompatible strategy (either by default or set manually).

I'm thinking that if None is detected it should print a different warning that the version couldn't be detected, but still try to proceed with the selected strategy rather than failing. At least then people won't think the problem is a bug in sbt-native-packager (or one of its downstream dependencies).

Originally posted by @TimMoore in #1230 (comment)

@muuki88
Copy link
Contributor

muuki88 commented Jun 12, 2019

At least then people won't think the problem is a bug in sbt-native-packager (or one of its downstream dependencies).

Hopefully 😂

I agree. We should hope for the best and only print a warning to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants