-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
old slf4j pulled by jdeb breaks sbt-web asset pipeline #291
Comments
The workaround is to force to a libraryDependencies ++= Seq(
"org.slf4j" % "slf4j-api" % "1.7.7" force(),
"org.slf4j" % "slf4j-nop" % "1.7.7" force(),
"org.slf4j" % "slf4j-jdk14" % "1.7.7" force(),
"org.slf4j" % "jcl-over-slf4j" % "1.7.7" force()
) |
It works, thanks! |
@jsuereth , I was not able to exclude the "org.vafer" % "jdeb" % "1.2" artifacts (Artifact("jdeb", "jar", "jar")) excludeAll(
ExclusionRule(organization = "org.slf4j")
) slf4j doesn't show up in the dependencies, but still there at runtime :/ |
Fixed in jdeb here: tcurdt/jdeb#174. Need a new jdeb release so that we can update sbt-native-packager to use it. Btw, the workaround above caused some issues in Play per the linked issue, so might want to be careful using it |
Thanks for putting this information here! Hopefully the release won't take two month :) |
@benmccann I saw your ticket [tcurdt/jdeb/issues/175]. I'm playing around with the though removing the jdeb support in a |
Pull request here to upgrade to 1.3 :-) #307 |
Also related, jdeb appears to have lots of version ranges and significantly hurt the activator offline repository. I'm actually debating whether or not it's worth it to try to do classloader isolation on jdeb rather than using it directly. i.e. we'd resolve it somewhere and use it via reflection rather than directly. In any case, these are all workable problems, just thought I'd share that slf4j isn't the only issue with jdeb's massive dependency list. |
@jsuereth good to know. looks like the version ranges aren't in jdeb directly, but are somewhere in the transitive dependency chain. it'd be worth upgrading to 1.3 and then seeing if the problem still exists or whether it's as severe since it removes three jdeb dependencies and upgrades most of the remaining to much newer versions |
@benmccann, @jsuereth I'm sure the upgrade will resolve a lot of stuff as all the maven2 dependencies which are more then 5 (?) years old are replaced. If there are still problems, we have to refactor this out :/ |
This is fixed now with 0.7.4 released! Looks like we can close this one =) |
After upgrading sbt-native-packager 0.7.2 from 0.7.2-RC2 in a Play 2.3 project, I'm getting this error when running
assets
:It's caused by
org.vafer:jdeb:1.2
which depends onorg.apache.maven:maven-core:2.2.1
, bringing tons ofslf4j-api:1.5.x
for related libraries.Is there any workaround to remove jdeb? I tried
addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % "0.7.2" exclude ("org.vafer", "jdeb"))
but had no luck.The text was updated successfully, but these errors were encountered: