-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play pid is a big caveat for people starting using sbt-native-packager. #602
Comments
That's true. And a big issue for everybody deploying play the first time.
This solution would definitely work. The big question here is, where to put this. sbt-play-pluginPutting the sbt-native-packagerWe could create a specific plugin like WDYT? |
For me it feels like other folders are treated the same way by adding a folder in the |
You are right. I was thinking too complicated. This should work smoothly. The challenge will be to make all bash scripts work correctly:
|
see also #607 |
Closing this as play as extensive documentation on the deployment configuration |
This line is everywhere in the documentation:
-Dpidfile.path=/var/run/${{app_name}}/play.pid
And usually is said to be added to
src/universal/conf/application.ini
whereas play actually usesdist/conf/application.ini
and the${{app_name}}
is also not replaced.So I was actually thinking about making a pull request to
play-sbt-plugin
but I realise you don't want athere by default because
/var/run
doesn't always exists.I think this could be solved by having a new folder in
app_home
calledrun
with the right permission that could be linked to/var/run/app_name
for the right packagers. Thenplay-sbt-plugin
could addThe text was updated successfully, but these errors were encountered: