Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with file associations in JDKNativePackager #643

Closed
DaveDeCaprio opened this issue Aug 5, 2015 · 4 comments
Closed

Issue with file associations in JDKNativePackager #643

DaveDeCaprio opened this issue Aug 5, 2015 · 4 comments
Assignees

Comments

@DaveDeCaprio
Copy link

When I ran the test-project-jdkpackager on windows with JDK 1.8.0_25, it gave me an error that fx:association elements can't be inside an fx:info. At least according to this page: https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html#BCGICFDB it seems that fx:assocation needs to be a top level element.

@metasim
Copy link
Member

metasim commented Aug 6, 2015

@DaveDeCaprio Would it be possible for you to try this with 1.8.0_40? There were significant improvements/changes with that release. We may need to add a check for the build number in the plugin (I wish Oracle had numbered it 1.8.1).

@DaveDeCaprio
Copy link
Author

Will test with that later tonight.

@DaveDeCaprio
Copy link
Author

Just tested with 1.8.0_51 and it worked fine. That's good enough for me. I'll close this since there is an easy enough workaround.

@metasim
Copy link
Member

metasim commented Aug 7, 2015

@DaveDeCaprio Thanks for giving it a try. My memory is that the file associations stuff was added with Build 40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants