Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to specify a docker command / docker binary #783

Closed
schmitch opened this issue Apr 21, 2016 · 1 comment
Closed

Add a way to specify a docker command / docker binary #783

schmitch opened this issue Apr 21, 2016 · 1 comment

Comments

@schmitch
Copy link
Contributor

Actually when deploying to Google Cloud I need to invoke the gcloud docker Command so that I could publish images. (it adds some token refresh mechanism but is actually just a wrapper of docker)
However due to the nature of sbt-native-packager I would need to run two steps instead of one to publish / deploy a new image to gcloud.

@muuki88
Copy link
Contributor

muuki88 commented Apr 25, 2016

Thanks for your feature request. I'm not sure how this would look like. Adding a way to customize the docker command itself seems like a big change for "1 instead of 2" steps.

I would recommend overriding the docker:publish or docker:publishLocal command.

Furthermore is deployment not in the scope of native packager. This boundary may not be as clear with docker as it is with other packaging formats, but supporting vendor specific deployment tools, is.

@muuki88 muuki88 closed this as completed Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants