Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variables in Command Not Handled #868

Closed
apeschel opened this issue Aug 19, 2016 · 1 comment
Closed

Environment Variables in Command Not Handled #868

apeschel opened this issue Aug 19, 2016 · 1 comment

Comments

@apeschel
Copy link
Contributor

Relevant code:

https://github.com/sbt/sbt-native-packager/blob/master/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template#L248-L255

If an environment variable is passed in via the command string, it is never interpolated.

For example:

command: ['-Dfoo.bar=$FOOBAR']

Will result in this script executing the program with the literal flag -Dfoo.bar=$FOOBAR

This means that there is no mechanism to handle shell interpolation via the command string/array at the moment.

@muuki88
Copy link
Contributor

muuki88 commented May 25, 2017

I think this feature is still not resolved, but at this point in time I would rather not implement this. There are plenty of options to deal with environment variables

  • the JavaServerAppPackaging supports sourcing of a etc configuration file
  • your application can read environment variables itself
  • you can add arbitrary code to the bash script
  • you can override the bash script if all other options are not enough

@muuki88 muuki88 closed this as completed May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants