Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker authentication fails with latest milestone #892

Closed
Daxten opened this issue Oct 10, 2016 · 4 comments
Closed

Docker authentication fails with latest milestone #892

Daxten opened this issue Oct 10, 2016 · 4 comments

Comments

@Daxten
Copy link

Daxten commented Oct 10, 2016

Hi,
I have problems with authentication using gitlab-builder / dockerindocker image.

Using version 1.1.4 my buildscripts all work, using the latest milestone I get authentication errors.
Is this a known issue? If not I would be happy to give you more detailed informations

@muuki88
Copy link
Contributor

muuki88 commented Oct 11, 2016

Hi,

Thanks for your report. This issue seems to be new. I'm a bit puzzled as we have not integrated anything around authentication so nothing that could actually break.

cc @fiadliel

@fiadliel
Copy link
Contributor

The default integration never did anything around auth. It assumes that you have already provided credentials so that docker push will work.

This was because docker push provided no way of giving credentials, other than setting them in the global (ambient) environment, and modifying the global environment seemed like a bad default for a build tool.

So it's an unusual correlation... certainly, please give more information, but I'd be surprised if the root cause had anything to do with this plugin.

@Daxten
Copy link
Author

Daxten commented Jun 13, 2017

y sorry that I didnt react here anymore, closing this is the right choice and I won't be able to reproduce a minimal example for this anymore.

@muuki88
Copy link
Contributor

muuki88 commented Jun 13, 2017

No problem 😉 and thanks for your understanding 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants