exec $java_cmd vs simple $java_cmd in bash script

[kardapoltsev]

If we'll able to set it in configs (e.g. fork in run) then it'll be possible to use bash script in java_server_application in /etc/init.d/ script to start the app. No the problem is in the pid of java process, which is used in start-stop-daemon.

What do you think about it?
In bash template:

${{exec_cmd}} "$java_cmd" 

And in bash script replacements smth like this:

replacements ++= Seq("exec_cmd" -> (if(fork) "exec" else ""))

[jsuereth]

Ah. I had forgotten that this alters the PID. Assuming non of the other features break, I'd be all for this. One of my goals (which may be impractical) is to have the same script to start an application or server and wrap them for rc.d or upstart. If we cant' acheive that, at least having as similar as possible the options would be good.

Would you have time to put your thoughts in a pull request? I'm not sure I understanding 100% what the correlation to fork in run is.

[kardapoltsev]

May be we could try simply remove exec and test that all other features work fine?

[jsuereth]

will do. Probably not today. I'll try to set aside tomorrow for sbt-native-packager work.

[kardapoltsev]

I'm still think that we should check this. /etc/init.d/ script will be simpler and more readable.

[jsuereth]

Ah, right. Lost track of this. NOW that we have pull request validation, you can create a pull request which will run our test scripts. I'll do it now on ubuntu and see what happens.

[jsuereth]

Appears to work. Leaving the PR open for someone to give a look-over before merging.