Make PositionImpl thread-safe #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
previously approved these changes
Dec 6, 2017
| } | ||
| } catch { | ||
| // TODO - catch ReflectiveOperationException once sbt is migrated to JDK7 | ||
| case ignored: Throwable => None |
There was a problem hiding this comment.
Should we postpone this change for an RC cycle?
There was a problem hiding this comment.
You have a hawk eye. Sure, I'll be fine with moving that change to 1.1.x.
There was a problem hiding this comment.
It's clearer when ignoring whitespace changes: https://github.com/sbt/zinc/pull/465/files?w=1.
dwijnand
previously approved these changes
Dec 6, 2017
jrudolph
reviewed
Dec 6, 2017
|
Reviewing this tomorrow. |
jvican
requested changes
Dec 8, 2017
| /** | ||
| * Strict and immutable implementation of Position. | ||
| */ | ||
| private[sbt] final class PositionImpl( |
There was a problem hiding this comment.
If we're only going to instantiate this class via its apply method in the companion, could we make this constructor private?
There was a problem hiding this comment.
Good suggestion. I'll make the change.
Fixes sbt#464 sbt/sbt#3623 Currently compiling a lot of Java code in CI environment causes NullPointerException, which is suspected of race condition around `javax.tools.Diagnostics[S]`, which is held by `PositionImpl` and then later accessed by async logging. This change makes the `PositionImpl` strict and immutable, and extracts it from a Java Diagnostics object. No other observable changes are introduced besides, hopefully the lack of NPE. Credit on the detective work goes to Lightbend Akka team ktoso, 2m, and jrudolph.
jvican
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
Fixes sbt/sbt#3623
Currently, compiling a lot of Java code in CI environment causes NullPointerException, which is
suspected of race condition around
javax.tools.Diagnostics[S], which is held byPositionImpland then later accessed by async logging.This change makes the
PositionImplstrict and immutable, and extracts it from a Java Diagnostics object. No other observable changes are introduced besides, hopefully the lack of NPE. Credit on the detective work goes to Lightbend Akka team @ktoso, @2m, and @jrudolph.